Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1920713002: X87: [interpreter] Heal closures when bytecode array is gone. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Heal closures when bytecode array is gone. port 5c8609de9d597000fdb92dffe954d7ed994488b2 (r35724) original commit message: This ensures the InterpreterEntryTrampoline heals code entry fields inside closures when being called without a valid bytecode array. This is preparatory work to allow removal of bytecode when switching some functions to other types of code. BUG= Committed: https://crrev.com/eb921c8a5807d5ef379eb323b6cbd00e5e2cce31 Cr-Commit-Position: refs/heads/master@{#35744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-25 02:13:28 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-25 02:18:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920713002/1
4 years, 8 months ago (2016-04-25 02:19:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 02:42:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 02:43:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb921c8a5807d5ef379eb323b6cbd00e5e2cce31
Cr-Commit-Position: refs/heads/master@{#35744}

Powered by Google App Engine
This is Rietveld 408576698