Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 19207002: Reland deprecation of HAllocateObject in favor of HAllocate. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland deprecation of HAllocateObject in favor of HAllocate. This essentially relands r14930 and r14935 with adaptions to the current code base. It models the instantiation of an implicit receiver for CallNew nodes in hydrogen using HAllocate together with generic stores instead of one specialized HAllocateObject instruction, hence creating a single choking point for inlined allocation in optimized code. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -492 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +64 lines, -8 lines 0 comments Download
M src/hydrogen-escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +12 lines, -46 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 5 months ago (2013-07-15 14:51:11 UTC) #1
Hannes Payer (out of office)
LGTM!
7 years, 5 months ago (2013-07-15 15:11:34 UTC) #2
Michael Starzinger
7 years, 5 months ago (2013-07-15 15:12:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698