|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable tests on MacBook Pro Retina with NVIDIA GPUs.
Now that these have been replaced on the main mac_chromium_rel_ng
trybot configuration by the newer AMD Retina machines, there should be
plenty of capacity, including for the optional GPU trybots. Re-enable
the tests on them.
BUG=550016, 572793
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org
Committed: https://crrev.com/8f2db981306b2efd4f9ad37abb73cd5afa65203a
Cr-Commit-Position: refs/heads/master@{#391427}
Patch Set 1 #Patch Set 2 : Rebased. Removed obsolete testers. #Patch Set 3 : Rebased. #
Messages
Total messages: 28 (15 generated)
Description was changed from ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 ========== to ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + cwallez@chromium.org, geofflang@chromium.org, jmadill@chromium.org, zmo@chromium.org
FYI. CQ'ing TBR'd.
Description was changed from ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Nice, LGTM
On 2016/04/23 05:01:53, Zhenyao Mo wrote: > lgtm Thanks. Mo, it looks like there are still some texturefiltering tests failing, e.g.: WebglConformance.deqp_functional_gles3_texturefiltering_cube_sizes_03 https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu... Could you please fix that next week and shepherd this CL through the commit queue? Thanks.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org, jmadill@chromium.org Link to the patchset: https://codereview.chromium.org/1920623002/#ps20001 (title: "Rebased. Removed obsolete testers.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org, jmadill@chromium.org Link to the patchset: https://codereview.chromium.org/1920623002/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/40001
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org ========== to ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org ========== to ========== Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org Committed: https://crrev.com/8f2db981306b2efd4f9ad37abb73cd5afa65203a Cr-Commit-Position: refs/heads/master@{#391427} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8f2db981306b2efd4f9ad37abb73cd5afa65203a Cr-Commit-Position: refs/heads/master@{#391427} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
