Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1920623002: Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable tests on MacBook Pro Retina with NVIDIA GPUs. Now that these have been replaced on the main mac_chromium_rel_ng trybot configuration by the newer AMD Retina machines, there should be plenty of capacity, including for the optional GPU trybots. Re-enable the tests on them. BUG=550016, 572793 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org, geofflang@chromium.org, cwallez@chromium.org, zmo@chromium.org Committed: https://crrev.com/8f2db981306b2efd4f9ad37abb73cd5afa65203a Cr-Commit-Position: refs/heads/master@{#391427}

Patch Set 1 #

Patch Set 2 : Rebased. Removed obsolete testers. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -163 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 2 8 chunks +1 line, -65 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 1 chunk +0 lines, -95 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 2 5 chunks +648 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 8 months ago (2016-04-23 04:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/1
4 years, 8 months ago (2016-04-23 04:55:53 UTC) #6
Zhenyao Mo
lgtm
4 years, 8 months ago (2016-04-23 05:01:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/177162)
4 years, 8 months ago (2016-04-23 05:48:32 UTC) #9
Jamie Madill
Nice, LGTM
4 years, 8 months ago (2016-04-23 18:41:38 UTC) #10
Ken Russell (switch to Gerrit)
On 2016/04/23 05:01:53, Zhenyao Mo wrote: > lgtm Thanks. Mo, it looks like there are ...
4 years, 8 months ago (2016-04-23 21:50:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/20001
4 years, 7 months ago (2016-05-03 01:07:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/781)
4 years, 7 months ago (2016-05-03 02:44:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/20001
4 years, 7 months ago (2016-05-03 23:51:54 UTC) #18
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 01:12:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920623002/40001
4 years, 7 months ago (2016-05-04 01:52:01 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 02:52:29 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 02:53:52 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f2db981306b2efd4f9ad37abb73cd5afa65203a
Cr-Commit-Position: refs/heads/master@{#391427}

Powered by Google App Engine
This is Rietveld 408576698