third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp - Issue 1920583002: NOT FOR LANDING: Hack up CSSParser for speed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

Issue 1920583002: NOT FOR LANDING: Hack up CSSParser for speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing consts. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

index 51014658dd27281ffba820e298957ff4838f9008..8fcaae43a482f8728ea9b36066d2202b6512cddf 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

@@ -68,7 +68,10 @@ void CSSParserToken::convertToDimensionWithUnit(CSSParserString unit)

ASSERT(m_type == NumberToken);

m_type = DimensionToken;

initValueFromCSSParserString(unit);

- m_unit = static_cast<unsigned>(CSSPrimitiveValue::fromName(unit));

+ if (unit.is8Bit())

+ m_unit = static_cast<unsigned>(CSSPrimitiveValue::fromName(unit.characters8(), unit.length()));

+ else

+ m_unit = static_cast<unsigned>(CSSPrimitiveValue::fromName(unit.characters16(), unit.length()));

}

void CSSParserToken::convertToPercentage()