Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1920483002: MediaRecorderHandler and WebmMuxer: add support for H264. (Closed)

Created:
4 years, 8 months ago by mcasas
Modified:
4 years, 7 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorderHandler and WebmMuxer: add support for H264. This CL adds support for H264 codec type in both WebmMuxer and MediaRecorderHandler. Support for H264 (and other) codecs was added to libwebm (which underlies WebmMuxer) in [1], by flipping the Doc Type indication of the webm file from "webm" to "matroska". MediaRecorder Handler basically just expands the boolean indication vp9 yes/no into using the enum class CodecId from VideoTrackRecorder. [1] https://chromium-review.googlesource.com/340298 BUG=601636 TEST= extended unit tests playground CL @ https://crrev.com/1886123002/ Committed: https://crrev.com/913419cf02929813a7ca8d1584fb42fc55d5e10d Cr-Commit-Position: refs/heads/master@{#390670}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : emircan@ comments #

Patch Set 3 : Addressed TODO (V_MPEG4/ISO/AVC) and adapted unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -27 lines) Patch
M content/renderer/media/media_recorder_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 1 2 7 chunks +40 lines, -11 lines 0 comments Download
M content/renderer/media/media_recorder_handler_unittest.cc View 1 2 5 chunks +12 lines, -5 lines 0 comments Download
M media/muxers/webm_muxer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/muxers/webm_muxer.cc View 1 2 3 chunks +20 lines, -5 lines 0 comments Download
M media/muxers/webm_muxer_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
mcasas
emircan@ PTAL, notwithstanding the comment in the CL description that says: > NOTE: https://crrev.com/1912283002/ and ...
4 years, 8 months ago (2016-04-22 22:22:55 UTC) #5
emircan
lgtm % nits. https://codereview.chromium.org/1920483002/diff/40001/content/renderer/media/media_recorder_handler.cc File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/1920483002/diff/40001/content/renderer/media/media_recorder_handler.cc#newcode47 content/renderer/media/media_recorder_handler.cc:47: default: If you remove default case, ...
4 years, 8 months ago (2016-04-25 19:26:16 UTC) #6
mcasas
https://codereview.chromium.org/1920483002/diff/40001/content/renderer/media/media_recorder_handler.cc File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/1920483002/diff/40001/content/renderer/media/media_recorder_handler.cc#newcode47 content/renderer/media/media_recorder_handler.cc:47: default: On 2016/04/25 19:26:15, emircan wrote: > If you ...
4 years, 8 months ago (2016-04-26 18:13:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920483002/100001
4 years, 7 months ago (2016-04-29 16:35:37 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 7 months ago (2016-04-29 16:40:13 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:25 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/913419cf02929813a7ca8d1584fb42fc55d5e10d
Cr-Commit-Position: refs/heads/master@{#390670}

Powered by Google App Engine
This is Rietveld 408576698