Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1920473003: Use correct annotation for JS names (Closed)

Created:
4 years, 8 months ago by vsm
Modified:
4 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use correct annotation for JS names Did we switch from "@JS" to "@JsName"? R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b40b804a1e1bb5175129a984ca0b03788a8ec9f6

Patch Set 1 #

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -366 lines) Patch
M lib/runtime/dart_sdk.js View 167 chunks +365 lines, -365 lines 0 comments Download
M lib/src/compiler/js_interop.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
vsm
4 years, 8 months ago (2016-04-22 19:54:57 UTC) #3
Jacob
We need to support both. @JsName is what dart2js uses internally. @JS is the publicly ...
4 years, 8 months ago (2016-04-25 14:50:39 UTC) #4
vsm
On 2016/04/25 14:50:39, Jacob wrote: > We need to support both. > @JsName is what ...
4 years, 8 months ago (2016-04-25 14:52:43 UTC) #5
vsm
On 2016/04/25 14:52:43, vsm wrote: > On 2016/04/25 14:50:39, Jacob wrote: > > We need ...
4 years, 8 months ago (2016-04-25 15:26:54 UTC) #6
Jacob
lgtm
4 years, 8 months ago (2016-04-25 15:32:06 UTC) #7
vsm
4 years, 8 months ago (2016-04-25 15:34:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b40b804a1e1bb5175129a984ca0b03788a8ec9f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698