Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1920463003: Fix HttpStreamParser fuzzer (again) (Closed)

Created:
4 years, 8 months ago by mmenke
Modified:
4 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix HttpStreamParser fuzzer. It was failing to read the body. 0 while reading the headers means OK, while 0 while reading the body means the connection was closed. I fixed this issue two weeks ago, but then re-introduced it in a refactor. I think that shows how weird and confusing network stack result handling is. :( BUG=598037 Committed: https://crrev.com/d284559ad772c498d5dae1a88d11a041f2941ffe Cr-Commit-Position: refs/heads/master@{#389314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M net/http/http_stream_parser_fuzzer.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mmenke
*grumble*....
4 years, 8 months ago (2016-04-22 20:57:57 UTC) #2
eroman
you mean there are problems from overloading the meaning of a single signed integer between ...
4 years, 8 months ago (2016-04-22 22:13:00 UTC) #3
eroman
lgtm
4 years, 8 months ago (2016-04-22 22:13:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920463003/1
4 years, 8 months ago (2016-04-22 22:52:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 00:01:00 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:03:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d284559ad772c498d5dae1a88d11a041f2941ffe
Cr-Commit-Position: refs/heads/master@{#389314}

Powered by Google App Engine
This is Rietveld 408576698