[css-flexbox] Implement new abspos handling

third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
     // Returns -1 if the height of this flexbox is indefinite
     LayoutUnit computeDefiniteLogicalWidth();
     LayoutUnit computeDefiniteLogicalHeight();
 
     LayoutUnit crossSizeForPercentageResolution(const LayoutBox& child);
     LayoutUnit mainSizeForPercentageResolution(const LayoutBox& child);
     LayoutUnit childLogicalHeightForPercentageResolution(const LayoutBox& child);
     LayoutUnit childLogicalWidthForPercentageResolution(const LayoutBox& child);
 
     void clearCachedMainSizeForChild(const LayoutBox& child);
+
+    LayoutUnit staticMainAxisPositionForPositionedChild(const LayoutBox& child);
+    LayoutUnit staticCrossAxisPositionForPositionedChild(const LayoutBox& child);
+
+    LayoutUnit staticInlinePositionForPositionedChild(const LayoutBox& child);
+    LayoutUnit staticBlockPositionForPositionedChild(const LayoutBox& child);
+

[eae, 2016/04/25 02:37:28]

Having a setter return a bool is a bit unusual. You might want to add a comment
explaining the return value.

[cbiesinger, 2016/04/26 18:21:56]

Done.

+    bool setStaticPositionForPositionedLayout(LayoutBox& child);
 protected:
     void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override;
 
     void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
     void removeChild(LayoutObject*) override;
 
 private:
     enum FlexSign {
         PositiveFlexibility,
         NegativeFlexibility,
     };
 
-    enum PositionedLayoutMode {
-        FlipForRowReverse,
-        NoFlipForRowReverse,
-    };
-
     enum ChildLayoutType {
         LayoutIfNeeded,
         ForceLayout,
         NeverLayout
     };
 
     enum class TransformedWritingMode {
         TopToBottomWritingMode, RightToLeftWritingMode, LeftToRightWritingMode, BottomToTopWritingMode
     };
 
@@ skipping 70 matching lines @@
     LayoutUnit adjustChildSizeForMinAndMax(const LayoutBox& child, LayoutUnit childSize);
     LayoutUnit adjustChildSizeForAspectRatioCrossAxisMinAndMax(const LayoutBox& child, LayoutUnit childSize);
     // The hypothetical main size of an item is the flex base size clamped according to its min and max main size properties
     bool computeNextFlexLine(OrderedFlexItemList& orderedChildren, LayoutUnit& sumFlexBaseSize, double& totalFlexGrow, double& totalFlexShrink, double& totalWeightedFlexShrink, LayoutUnit& sumHypotheticalMainSize, bool relayoutChildren);
 
     bool resolveFlexibleLengths(FlexSign, const OrderedFlexItemList&, LayoutUnit availableFreeSpace, LayoutUnit& remainingFreeSpace, double& totalFlexGrow, double& totalFlexShrink, double& totalWeightedFlexShrink, InflexibleFlexItemSize&, Vector<LayoutUnit, 16>& childSizes);
     void freezeViolations(const Vector<Violation>&, LayoutUnit& availableFreeSpace, double& totalFlexGrow, double& totalFlexShrink, double& totalWeightedFlexShrink, InflexibleFlexItemSize&);
 
     void resetAutoMarginsAndLogicalTopInCrossAxis(LayoutBox& child);
     void setOverrideMainAxisSizeForChild(LayoutBox& child, LayoutUnit childPreferredSize);
-    void prepareChildForPositionedLayout(LayoutBox& child, LayoutUnit mainAxisOffset, LayoutUnit crossAxisOffset, PositionedLayoutMode);
+    void prepareChildForPositionedLayout(LayoutBox& child);
     size_t numberOfInFlowPositionedChildren(const OrderedFlexItemList&) const;
     void layoutAndPlaceChildren(LayoutUnit& crossAxisOffset, const OrderedFlexItemList&, const Vector<LayoutUnit, 16>& childSizes, LayoutUnit availableFreeSpace, bool relayoutChildren, SubtreeLayoutScope&, Vector<LineContext>&);
     void layoutColumnReverse(const OrderedFlexItemList&, LayoutUnit crossAxisOffset, LayoutUnit availableFreeSpace);
     void alignFlexLines(Vector<LineContext>&);
     void alignChildren(const Vector<LineContext>&);
     void applyStretchAlignmentToChild(LayoutBox& child, LayoutUnit lineCrossAxisExtent);
     void flipForRightToLeftColumn();
     void flipForWrapReverse(const Vector<LineContext>&, LayoutUnit crossAxisStartEdge);
 
     float countIntrinsicSizeForAlgorithmChange(LayoutUnit maxPreferredWidth, LayoutBox* child, float previousMaxContentFlexFraction) const;
 
     // This is used to cache the preferred size for orthogonal flow children so we don't have to relayout to get it
     HashMap<const LayoutObject*, LayoutUnit> m_intrinsicSizeAlongMainAxis;
 
     // This set is used to keep track of which children we laid out in this current layout iteration.
     // We need it because the ones in this set may need an additional layout pass for correct stretch alignment
     // handling, as the first layout likely did not use the correct value for percentage sizing of children.
     HashSet<const LayoutObject*> m_relaidOutChildren;
 
     mutable OrderIterator m_orderIterator;
     int m_numberOfInFlowChildrenOnFirstLine;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox());
 
 } // namespace blink
 
 #endif // LayoutFlexibleBox_h