Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: media/cdm/aes_decryptor_unittest.cc

Issue 1920433003: EME: Address TODOs related to the removal of prefixed EME (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cdm/aes_decryptor.cc ('K') | « media/cdm/aes_decryptor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/aes_decryptor_unittest.cc
diff --git a/media/cdm/aes_decryptor_unittest.cc b/media/cdm/aes_decryptor_unittest.cc
index 7462010793fefa197f00d01978663ebaf89ad1ef..501438a31c559506757df5d2fc4338e93e90a195 100644
--- a/media/cdm/aes_decryptor_unittest.cc
+++ b/media/cdm/aes_decryptor_unittest.cc
@@ -339,18 +339,9 @@ class AesDecryptorTest : public testing::TestWithParam<std::string> {
cdm_->CloseSession(session_id, CreatePromise(RESOLVED));
}
- // Removes the session specified by |session_id|. This should simply do a
- // CloseSession().
- // TODO(jrummell): Clean this up when the prefixed API is removed.
- // http://crbug.com/249976.
+ // Only persistent sessions can be removed.
void RemoveSession(const std::string& session_id) {
- if (GetParam() == "AesDecryptor") {
- EXPECT_CALL(*this, OnSessionClosed(session_id));
- cdm_->RemoveSession(session_id, CreatePromise(RESOLVED));
- } else {
- // CdmAdapter fails as only persistent sessions can be removed.
- cdm_->RemoveSession(session_id, CreatePromise(REJECTED));
- }
+ cdm_->RemoveSession(session_id, CreatePromise(REJECTED));
}
MOCK_METHOD2(OnSessionKeysChangeCalled,
@@ -766,8 +757,6 @@ TEST_P(AesDecryptorTest, CloseSession) {
}
TEST_P(AesDecryptorTest, RemoveSession) {
- // TODO(jrummell): Clean this up when the prefixed API is removed.
ddorwin 2016/06/23 01:06:47 I'm not sure what this meant other than all the ot
jrummell 2016/06/23 17:20:16 When I added the comment the test was simply Remov
- // http://crbug.com/249976.
std::string session_id = CreateSession(key_id_);
scoped_refptr<DecoderBuffer> encrypted_buffer = CreateEncryptedBuffer(
encrypted_data_, key_id_, iv_, no_subsample_entries_);
« media/cdm/aes_decryptor.cc ('K') | « media/cdm/aes_decryptor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698