media/base/android/java/src/org/chromium/media/MediaDrmBridge.java - Issue 1920433003: EME: Address TODOs related to the removal of prefixed EME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

Issue 1920433003: EME: Address TODOs related to the removal of prefixed EME (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update per crbug.com/616166: Remove NOTREACHED and re-enable test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

diff --git a/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java b/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

index add05056accd59fbb60462ee059763266c32c228..25ffb1959d52985456972ff9fa1131370cac9bb5 100644

--- a/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

+++ b/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

@@ -752,9 +752,8 @@ public class MediaDrmBridge {

return;

}

- // TODO(xhwang): DCHECK this now that prefixed EME is deprecated.

- // https://crbug.com/249976

if (!sessionExists(sessionId)) {

+ assert false; // Should never happen.

onPromiseRejected(

promiseId, "Invalid session in updateSession: " + bytesToHexString(sessionId));

return;

« no previous file with comments | « content/renderer/media/cdm/render_cdm_factory.cc ('k') | media/cdm/aes_decryptor.cc » ('j') | no next file with comments »