Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920423003: recipe engine: remove Path.default_tostring_fn (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

recipe engine: remove Path.default_tostring_fn All users of Path should add path recipe module to DEPS. BUG=chromium:605919 Committed: https://github.com/luci/recipes-py/commit/a9d53aaab5486130b29feb22ca1425c2c42af358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M recipe_engine/config_types.py View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-27 13:44:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920423003/1
4 years, 7 months ago (2016-04-27 13:44:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 14:15:33 UTC) #6
martiniss
lgtm
4 years, 7 months ago (2016-04-27 21:35:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920423003/1
4 years, 7 months ago (2016-05-02 07:21:54 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 07:25:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/a9d53aaab5486130b29feb22ca1425c2c42...

Powered by Google App Engine
This is Rietveld 408576698