tests/PaintTest.cpp - Issue 1920423002: Prototype code that turns any/every flattenable into JSON

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PaintTest.cpp

Issue 1920423002: Prototype code that turns any/every flattenable into JSON (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Interfacification. Tweaks to SkPaint and ordering of name vs. fields Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PaintTest.cpp

diff --git a/tests/PaintTest.cpp b/tests/PaintTest.cpp

index 253ce86769dad008226c5d2b656c77b94ffbf558..c972670893dab6d08e6adc5fb1aed4364e36c000 100644

--- a/tests/PaintTest.cpp

+++ b/tests/PaintTest.cpp

@@ -255,7 +255,7 @@ DEF_TEST(Paint_flattening, reporter) {

FOR_SETUP(n, encodings, setTextEncoding)

FOR_SETUP(p, styles, setStyle)

- SkWriteBuffer writer;

+ SkBinaryWriteBuffer writer;

paint.flatten(writer);

const uint32_t* written = writer.getWriter32()->contiguousArray();

@@ -294,7 +294,7 @@ DEF_TEST(Paint_MoreFlattening, r) {

paint.setXfermode(SkXfermode::Make(SkXfermode::kModulate_Mode));

paint.setLooper(nullptr); // Default value, ignored.

- SkWriteBuffer writer;

+ SkBinaryWriteBuffer writer;

paint.flatten(writer);

SkReadBuffer reader(writer.getWriter32()->contiguousArray(), writer.bytesWritten());