Chromium Code Reviews
Description[Mac] Add testing code to expose an NSColor memory leak.
AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak. While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.
This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.
http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display
Patch Set 1 #Patch Set 2 : Adjust suppression to work for keyword-drawing, too. #
Total comments: 1
Patch Set 3 : Remove egregious s/private/public/ leftover from prototyping. #
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||