Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1920293005: Improve code for shifts and bitwise operations. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve code for shifts and bitwise operations. - JavaScript shifts can be used for operands in certain ranges. - Coercion from signed-32 to unsigned-32 can be omitted if - it is a no-op - the context performs the coercion - the context is insensitive to the most significant bit R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ec95b3c45819f4d0de847588fdaa752a8e4651fb

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -148 lines) Patch
M lib/runtime/dart_sdk.js View 67 chunks +144 lines, -144 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 3 chunks +129 lines, -2 lines 0 comments Download
M test/codegen/expect/notnull.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
sra1
4 years, 7 months ago (2016-04-29 00:44:12 UTC) #5
Jennifer Messerly
I don't know if someone who knows these bitops better wants to take a look ...
4 years, 7 months ago (2016-04-29 17:06:17 UTC) #7
sra1
4 years, 7 months ago (2016-04-29 19:22:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:50001) manually as
ec95b3c45819f4d0de847588fdaa752a8e4651fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698