scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json - Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json

Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Changes based on code review. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SwarmingMSAN.json ('k') | scripts/slave/recipes/skia/swarm_trigger.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json

diff --git a/scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json b/scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json

index 30bbbc51eb58a1389ae59de6d4933c1727bab59d..43dec118117e9d1249841354df8fa93b47ce8f96 100644

--- a/scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json

+++ b/scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json

@@ -68,7 +68,7 @@

"python",

"-u",

"\nimport os, sys\nfrom common import chromium_utils # Error? See https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n chromium_utils.RemoveDirectory(sys.argv[1])\n",

- "[SWARM_OUT_DIR]\\dm"

+ "[CUSTOM_[SWARM_OUT_DIR]]\\dm"

"env": {

"PYTHONPATH": "build\\scripts"

@@ -90,7 +90,7 @@

"python",

"-u",

"\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os.path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",

- "[SWARM_OUT_DIR]\\dm",

+ "[CUSTOM_[SWARM_OUT_DIR]]\\dm",

"511"

"name": "makedirs dm",

@@ -222,7 +222,7 @@

"--uninterestingHashesFile",

"[SLAVE_BUILD]\\tmp\\uninteresting_hashes.txt",

"--writePath",

- "[SWARM_OUT_DIR]\\dm",

+ "[CUSTOM_[SWARM_OUT_DIR]]\\dm",

"--nogpu",

"--dummy-flags"