scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json - Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json

Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Changes based on code review. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_compile.py ('k') | scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-CMake.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json

diff --git a/scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json b/scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json

index c8e6e7703f227101c93a3a69decd21377fa8ce80..82a84bcb387c563570e3015d48aadbcbafb5f19e 100644

--- a/scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json

+++ b/scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json

@@ -139,7 +139,7 @@

"-u",

"import errno\nimport glob\nimport os\nimport shutil\nimport sys\n\nsrc = sys.argv[1]\ndst = sys.argv[2]\nbuild_products_whitelist = ['dm', 'dm.exe', 'nanobench', 'nanobench.exe', '*.so', '*.dll', '*.dylib', 'skia_launcher', 'lib/*.so', 'iOSShell.app', 'iOSShell.ipa']\n\ntry:\n os.makedirs(dst)\nexcept OSError as e:\n if e.errno != errno.EEXIST:\n raise\n\nfor pattern in build_products_whitelist:\n path = os.path.join(src, pattern)\n for f in glob.glob(path):\n dst_path = os.path.join(dst, os.path.relpath(f, src))\n if not os.path.isdir(os.path.dirname(dst_path)):\n os.makedirs(os.path.dirname(dst_path))\n print 'Copying build product %s to %s' % (f, dst_path)\n shutil.move(f, dst_path)\n",

"[CUSTOM_/_B_CACHE]/skia/xcodebuild/Release-iphoneos",

- "[SWARM_OUT_DIR]/out/Release"

+ "[CUSTOM_[SWARM_OUT_DIR]]/out/Release"

"name": "copy build products",

"~followup_annotations": [