masters/master.client.skia.fyi/builders.cfg - Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming.

Side by Side Diff: masters/master.client.skia.fyi/builders.cfg

Issue 1920283002: Modify Skia recipes to allow running XSAN on Swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | masters/master.client.skia.fyi/slaves.cfg » ('j') | scripts/slave/recipe_modules/skia/xsan_flavor.py » ('J')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 builders = [	5 builders = [

6 { 'name': 'Housekeeper-PerCommit', 'recipe': 'skia/housekeeper_percommit' },	6 { 'name': 'Housekeeper-PerCommit', 'recipe': 'skia/housekeeper_percommit' },

7 { 'name': 'Housekeeper-Nightly-RecreateSKPs_Canary',	7 { 'name': 'Housekeeper-Nightly-RecreateSKPs_Canary',

8 'recipe': 'skia/recreate_skps', 'do_trybot': False,	8 'recipe': 'skia/recreate_skps', 'do_trybot': False,

9 'scheduler': 'skia_nightly' },	9 'scheduler': 'skia_nightly' },

10 { 'name': 'Housekeeper-Weekly-RecreateSKPs',	10 { 'name': 'Housekeeper-Weekly-RecreateSKPs',

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 { 'name': 'Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming',	43 { 'name': 'Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming',

44 'recipe': 'skia/swarm_trigger' },	44 'recipe': 'skia/swarm_trigger' },

45 { 'name': 'Perf-Win-MSVC-ShuttleB-CPU-AVX2-x86-Release-Swarming',	45 { 'name': 'Perf-Win-MSVC-ShuttleB-CPU-AVX2-x86-Release-Swarming',

46 'recipe': 'skia/swarm_trigger' },	46 'recipe': 'skia/swarm_trigger' },

47 { 'name': 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Swarming',	47 { 'name': 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Swarming',

48 'recipe': 'skia/swarm_trigger' },	48 'recipe': 'skia/swarm_trigger' },

49 { 'name': 'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming',	49 { 'name': 'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming',

50 'recipe': 'skia/swarm_trigger' },	50 'recipe': 'skia/swarm_trigger' },

51 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming',	51 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming',

52 'recipe': 'skia/swarm_trigger' },	52 'recipe': 'skia/swarm_trigger' },

53 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SwarmingASAN',	53 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SwarmingASAN',

54 'recipe': 'skia/swarm_trigger' },	54 'recipe': 'skia/swarm_trigger' },

55 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SwarmingMSAN',	55 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SwarmingMSAN',
	borenet 2016/05/04 11:15:55 Is this an important difference? Is this an important difference? dogben 2016/05/04 13:48:02 When I added these, I hadn't realized that the cur Show quoted text On 2016/05/04 at 11:15:55, borenet wrote: > Is this an important difference? When I added these, I hadn't realized that the current ASAN and MSAN bots are Debug but the TSAN bot is Release. I had copy-and-pasted TSAN for ASAN and MSAN. There will definitely be a difference, because Debug will enable code/asserts that might not be XSAN-clean. I don't know how important that is. My preference is that we don't introduce more differences between the current bot and the new bot. borenet 2016/05/04 13:52:58 Agreed. Show quoted text On 2016/05/04 13:48:02, Ben Wagner wrote: > On 2016/05/04 at 11:15:55, borenet wrote: > > Is this an important difference? > > When I added these, I hadn't realized that the current ASAN and MSAN bots are > Debug but the TSAN bot is Release. I had copy-and-pasted TSAN for ASAN and MSAN. > > There will definitely be a difference, because Debug will enable code/asserts > that might not be XSAN-clean. I don't know how important that is. > > My preference is that we don't introduce more differences between the current > bot and the new bot. Agreed.
56 'recipe': 'skia/swarm_trigger' },	56 'recipe': 'skia/swarm_trigger' },

57 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SwarmingTSAN',	57 { 'name': 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SwarmingTSAN',

58 'recipe': 'skia/swarm_trigger' },	58 'recipe': 'skia/swarm_trigger' },

59 { 'name': 'Test-Win-MSVC-ShuttleB-CPU-AVX2-x86-Release-Swarming',	59 { 'name': 'Test-Win-MSVC-ShuttleB-CPU-AVX2-x86-Release-Swarming',

60 'recipe': 'skia/swarm_trigger' },	60 'recipe': 'skia/swarm_trigger' },

61 ]	61 ]

OLD	NEW