runtime/vm/object.cc - Issue 1920263002: Print only native stack trace when crashing in IsInstantiated (debugging code)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1920263002: Print only native stack trace when crashing in IsInstantiated (debugging code) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index c87853d4120cf711d0329ccb0c7dc3c53fc71ea9..8e214c7beb5553cbbe82f13282948ce32a1efcd8 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -15516,8 +15516,7 @@ TokenPosition AbstractType::token_pos() const {

bool AbstractType::IsInstantiated(TrailPtr trail) const {

// AbstractType is an abstract class.

// TODO(srdjan) : Remove temporary code.

- Profiler::DumpStackTrace(false);

- Profiler::DumpStackTrace(true);

+ Profiler::DumpStackTrace(true); // Only native stack trace.

if (Compiler::IsBackgroundCompilation()) {

UNREACHABLE();

}

« no previous file with comments | « no previous file | runtime/vm/profiler.cc » ('j') | no next file with comments »