Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: chrome/browser/resources/settings/device_page/display.js

Issue 1920253002: Refactors parse_html_subset() into i18n_behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/display.js
diff --git a/chrome/browser/resources/settings/device_page/display.js b/chrome/browser/resources/settings/device_page/display.js
index 0bbf2f3888d5c5908dfce321d65b01625a7a9053..07873c0cd0fca1e59a2e2df6b4ba12f5dd2a7c42 100644
--- a/chrome/browser/resources/settings/device_page/display.js
+++ b/chrome/browser/resources/settings/device_page/display.js
@@ -161,7 +161,7 @@ Polymer({
if (this.selectedDisplay.modes.length == 0) {
var widthStr = selectedDisplay.bounds.width.toString();
var heightStr = selectedDisplay.bounds.height.toString();
- return this.i18n('displayResolutionText', widthStr, heightStr);
+ return this.i18n('displayResolutionText', [widthStr, heightStr]);
}
if (isNaN(immediateSelectedModeIndex))
immediateSelectedModeIndex = this.getSelectedModeIndex_(selectedDisplay);
@@ -170,10 +170,10 @@ Polymer({
var widthStr = mode.width.toString();
var heightStr = mode.height.toString();
if (best)
- return this.i18n('displayResolutionTextBest', widthStr, heightStr);
+ return this.i18n('displayResolutionTextBest', [widthStr, heightStr]);
else if (mode.isNative)
- return this.i18n('displayResolutionTextNative', widthStr, heightStr);
- return this.i18n('displayResolutionText', widthStr, heightStr);
+ return this.i18n('displayResolutionTextNative', [widthStr, heightStr]);
+ return this.i18n('displayResolutionText', [widthStr, heightStr]);
},
/**

Powered by Google App Engine
This is Rietveld 408576698