Refactors parse_html_subset() into i18n_behavior.

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 264 matching lines @@
       // creating SUs with the same name (https://crbug.com/557445).
       var allOnCurrentDevice = supervisedUsers[i].onCurrentDevice;
       for (var j = i + 1; j < supervisedUsers.length; ++j) {
         if (supervisedUsers[j].name == this.profileName_) {
           nameIsUnique = false;
           allOnCurrentDevice = allOnCurrentDevice &&
              supervisedUsers[j].onCurrentDevice;
         }
       }
 
+      var opts = {
+        'substitutions':
+          [HTMLEscape(elide(this.profileName_, /* maxLength */ 50))],
+        'attrs': {
+          'id': function(node, value) {
+            return node.tagName == 'A' && value != '';
+          },
+          'is': function(node, value) {
+            return node.tagName == 'A' && value == 'action-link';
+          },
+          'role': function(node, value) {
+            return node.tagName == 'A' && value == 'link';
+          },
+          'tabindex': function(node, value) {
+            return node.tagName == 'A';
+          }
+        }
+      };
+
       this.handleMessage_(allOnCurrentDevice ?
           this.i18n('managedProfilesExistingLocalSupervisedUser') :
-          this.i18n('manageProfilesExistingSupervisedUser',
-               HTMLEscape(elide(this.profileName_, /* maxLength */ 50))));
+          this.i18nAdvanced('manageProfilesExistingSupervisedUser', opts));
       return;
     }
     // No existing supervised user's name matches the entered profile name.
     // Continue with creating the new supervised profile.
     this.createProfile_();
   },
 
   /**
    * Creates the new profile.
    * @private
@@ skipping 77 matching lines @@
    * Handles profile create/import warning/error message pushed by the browser.
    * @param {*} message An HTML warning/error message.
    * @private
    */
   handleMessage_: function(message) {
     this.createInProgress_ = false;
     this.message_ = '' + message;
   },
 
   /**
+   * Returns a translated message that contains link elements with 'id'
+   * attribute.
+   * @param {string} id The ID of the string to translate.
+   * @private
+   */
+  i18nAllowIDAttr_: function(id) {
+    var opts = {
+      'attrs': {
+        'id' : function(node, value) {
+          return node.tagName == 'A' && value != '';

[Dan Beam, 2016/05/05 16:43:36]

i suppose checking for tagName == 'A' isn't bad, but why != ''?

[Moe, 2016/05/06 14:24:59]

It's not needed. removed.

+        }
+      }
+    };
+
+    return this.i18nAdvanced(id, opts);

[Dan Beam, 2016/05/05 16:43:36]

this would be so much prettier

  return this.i18nAdvanced(id, {attrs: {id: () => true}})

oh well, we can't use => everywhere yet :(

[Moe, 2016/05/06 14:24:59]

I agree. When can we start using ES6 in chromium? Also on a different note, I
saw a reviewer asking in a CL not to use 'let' instead of 'var'. Is the use of
'let' discouraged?

+  },
+
+  /**
    * Computed binding determining which profile icon button is toggled on.
    * @param {string} iconUrl icon URL of a given icon button.
    * @param {string} profileIconUrl Currently selected icon URL.
    * @return {boolean}
    * @private
    */
   isActiveIcon_: function(iconUrl, profileIconUrl) {
     return iconUrl == profileIconUrl;
   },
 
@@ skipping 27 matching lines @@
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());