Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 192023002: Revert 255755 "Define print format macros for NSInteger & NSUInt..." (Closed)

Created:
6 years, 9 months ago by Rick Byers
Modified:
6 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255755 "Define print format macros for NSInteger & NSUInt..." Reason for revert: caused unit test failures on Mac ASAN bots, eg: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/69/steps/base_unittests/logs/FormatNSInteger > Define print format macros for NSInteger & NSUInteger > > The size of NSInteger and NSUInteger varies between 32-bit and 64-bit > architectures, however does not provides macro to safely format them > and instead recommend casting the value to the larger version that is > used on 64-bit architecture. > > Using a cast could cause some formatting to be missed (if the type of > a variable changes), so instead we define our own macros to format those > types safely. > > BUG=349458 > > Review URL: https://codereview.chromium.org/187793003 TBR=sdefresne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M trunk/src/base/format_macros.h View 1 chunk +0 lines, -28 lines 0 comments Download
M trunk/src/base/mac/foundation_util_unittest.mm View 2 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rick Byers
6 years, 9 months ago (2014-03-08 17:56:01 UTC) #1
Rick Byers
Committed patchset #1 manually as r255781 (tree was closed).
6 years, 9 months ago (2014-03-08 17:56:08 UTC) #2
sdefresne
6 years, 9 months ago (2014-03-09 17:26:25 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698