|
|
Created:
4 years, 8 months ago by hiroshige Modified:
4 years, 7 months ago Reviewers:
sof CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_5c Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ParamStorageTraits from BeaconLoader.cpp
We are going to make WTF::bind() to depend less on ParamStorageTraits and
simplify ParamStorageTraits, for WTF::bind() refactoring and merging
WTF::bind() and base::Bind().
This CL removes uses of ParamStorageTraits from outside WTF::bind() to make
those activities easier.
BUG=597856
Committed: https://crrev.com/6f2f4d868c933bcce80427566d2bc985efdfc92b
Cr-Commit-Position: refs/heads/master@{#390319}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Total comments: 2
Patch Set 4 : Make private |m_data| only. #Messages
Total messages: 24 (11 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/20001
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hiroshige@chromium.org changed reviewers: + sigbjornf@opera.com
PTAL. This CL doesn't increase the binary size too much: On Linux 64-bit: Before: 175994992 ./out/Release/chrome 50360 ./out/Release/obj/third_party/WebKit/Source/core/loader/webcore_remaining.BeaconLoader.o After: 175994600 ./out/Release/chrome 50992 ./out/Release/obj/third_party/WebKit/Source/core/loader/webcore_remaining.BeaconLoader.o
could you outline the benefits?
Description was changed from ========== Remove ParamStorageTraits from BeaconLoader.cpp BUG= ========== to ========== Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 ==========
On 2016/04/26 15:42:17, sof wrote: > could you outline the benefits? Updated the CL description. Specifically, we might remove ParamStorageTraits for pointers.
On 2016/04/27 04:31:54, hiroshige wrote: > On 2016/04/26 15:42:17, sof wrote: > > could you outline the benefits? > > Updated the CL description. > Specifically, we might remove ParamStorageTraits for pointers. thanks, that's good context for everyone to include in the description. lgtm.
https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/loader/BeaconLoader.cpp (right): https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/loader/BeaconLoader.cpp:43: private: let's just have "private:" limit visibility for the m_data field in this and the other local classes here?
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/50001
https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/loader/BeaconLoader.cpp (right): https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/loader/BeaconLoader.cpp:43: private: On 2016/04/27 14:05:07, sof wrote: > let's just have "private:" limit visibility for the m_data field in this and the > other local classes here? Done.
The CQ bit was unchecked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com Link to the patchset: https://codereview.chromium.org/1920213002/#ps50001 (title: "Make private |m_data| only.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/50001
Message was sent while issue was closed.
Description was changed from ========== Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 ========== to ========== Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:50001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/6f2f4d868c933bcce80427566d2bc985efdfc92b Cr-Commit-Position: refs/heads/master@{#390319}
Message was sent while issue was closed.
Description was changed from ========== Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 ========== to ========== Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 Committed: https://crrev.com/6f2f4d868c933bcce80427566d2bc985efdfc92b Cr-Commit-Position: refs/heads/master@{#390319} ========== |