Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1920213002: Remove ParamStorageTraits from BeaconLoader.cpp (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_5c
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ParamStorageTraits from BeaconLoader.cpp We are going to make WTF::bind() to depend less on ParamStorageTraits and simplify ParamStorageTraits, for WTF::bind() refactoring and merging WTF::bind() and base::Bind(). This CL removes uses of ParamStorageTraits from outside WTF::bind() to make those activities easier. BUG=597856 Committed: https://crrev.com/6f2f4d868c933bcce80427566d2bc985efdfc92b Cr-Commit-Position: refs/heads/master@{#390319}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Make private |m_data| only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -100 lines) Patch
M third_party/WebKit/Source/core/loader/BeaconLoader.cpp View 1 2 3 3 chunks +107 lines, -100 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/20001
4 years, 8 months ago (2016-04-26 13:10:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/40001
4 years, 8 months ago (2016-04-26 13:44:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 14:57:55 UTC) #6
hiroshige
PTAL. This CL doesn't increase the binary size too much: On Linux 64-bit: Before: 175994992 ...
4 years, 8 months ago (2016-04-26 15:37:03 UTC) #8
sof
could you outline the benefits?
4 years, 8 months ago (2016-04-26 15:42:17 UTC) #9
hiroshige
On 2016/04/26 15:42:17, sof wrote: > could you outline the benefits? Updated the CL description. ...
4 years, 8 months ago (2016-04-27 04:31:54 UTC) #11
sof
On 2016/04/27 04:31:54, hiroshige wrote: > On 2016/04/26 15:42:17, sof wrote: > > could you ...
4 years, 7 months ago (2016-04-27 14:04:51 UTC) #12
sof
https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Source/core/loader/BeaconLoader.cpp File third_party/WebKit/Source/core/loader/BeaconLoader.cpp (right): https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Source/core/loader/BeaconLoader.cpp#newcode43 third_party/WebKit/Source/core/loader/BeaconLoader.cpp:43: private: let's just have "private:" limit visibility for the ...
4 years, 7 months ago (2016-04-27 14:05:07 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/50001
4 years, 7 months ago (2016-04-28 05:51:52 UTC) #15
hiroshige
https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Source/core/loader/BeaconLoader.cpp File third_party/WebKit/Source/core/loader/BeaconLoader.cpp (right): https://codereview.chromium.org/1920213002/diff/40001/third_party/WebKit/Source/core/loader/BeaconLoader.cpp#newcode43 third_party/WebKit/Source/core/loader/BeaconLoader.cpp:43: private: On 2016/04/27 14:05:07, sof wrote: > let's just ...
4 years, 7 months ago (2016-04-28 05:52:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920213002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920213002/50001
4 years, 7 months ago (2016-04-28 06:37:08 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 7 months ago (2016-04-28 07:27:11 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:45 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6f2f4d868c933bcce80427566d2bc985efdfc92b
Cr-Commit-Position: refs/heads/master@{#390319}

Powered by Google App Engine
This is Rietveld 408576698