Remove View::focusable().

ui/views/controls/label_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/compositor/canvas_painter.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/border.h"
+#include "ui/views/controls/link.h"
 #include "ui/views/test/focus_manager_test.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
 
 using base::ASCIIToUTF16;
 
 namespace views {
 
 typedef ViewsTestBase LabelTest;
 
 class LabelFocusTest : public FocusManagerTest {
  public:
   LabelFocusTest() {}
   ~LabelFocusTest() override {}
 
  protected:
   views::Label* label() { return label_; }
 
  private:
   // FocusManagerTest:
   void InitContentView() override {
-    label_ = new views::Label();
+    // A link is a focusable label.
+    label_ = new views::Link();
     GetContentsView()->AddChildView(label_);
   }
 
   views::Label* label_;
 };
 
 // All text sizing measurements (width and height) should be greater than this.
 const int kMinTextDimension = 4;
 
 // A test utility function to set the application default text direction.
@@ skipping 551 matching lines @@
   gfx::Canvas canvas(label.GetPreferredSize(), 1.0f, true);
   label.Paint(ui::CanvasPainter(&canvas, 1.f).context());
 
   // There's only one 'line', RenderText itself supports multiple lines.
   EXPECT_EQ(1u, label.lines_.size());
 }
 #endif
 
 TEST_F(LabelFocusTest, FocusBounds) {
   label()->SetText(ASCIIToUTF16("Example"));
-  gfx::Size normal_size = label()->GetPreferredSize();
-
-  label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   label()->RequestFocus();
   gfx::Size focusable_size = label()->GetPreferredSize();
-  // Focusable label requires larger size to paint the focus rectangle.
-  EXPECT_GT(focusable_size.width(), normal_size.width());
-  EXPECT_GT(focusable_size.height(), normal_size.height());
 
   label()->SizeToPreferredSize();
   gfx::Rect focus_bounds = label()->GetFocusBounds();
   EXPECT_EQ(label()->GetLocalBounds().ToString(), focus_bounds.ToString());
 
   label()->SetBounds(
       0, 0, focusable_size.width() * 2, focusable_size.height() * 2);
   label()->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   focus_bounds = label()->GetFocusBounds();
   EXPECT_EQ(0, focus_bounds.x());
@@ skipping 10 matching lines @@
   EXPECT_EQ(focusable_size.ToString(), focus_bounds.size().ToString());
 
   label()->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   label()->SetElideBehavior(gfx::FADE_TAIL);
   label()->SetBounds(0, 0, focusable_size.width() / 2, focusable_size.height());
   focus_bounds = label()->GetFocusBounds();
   EXPECT_EQ(0, focus_bounds.x());
   EXPECT_EQ(focusable_size.width() / 2, focus_bounds.width());
 }
 
-TEST_F(LabelFocusTest, EmptyLabel) {

[karandeepb, 2016/04/27 08:04:40]

An empty link is not focusable. Hence this test can be removed.

-  label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
-  label()->RequestFocus();
-  label()->SizeToPreferredSize();
-
-  gfx::Rect focus_bounds = label()->GetFocusBounds();
-  EXPECT_FALSE(focus_bounds.IsEmpty());
-  EXPECT_LT(label()->font_list().GetHeight(), focus_bounds.height());
-}
-
 }  // namespace views