Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1920183002: Remove owner ppi@ from histograms. (Closed)

Created:
4 years, 8 months ago by ppi
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove owner ppi@ from histograms. ppi@ doesn't work on Chromium these days. Committed: https://crrev.com/4991ff9b338a6241ed9e69328e5acb0d25bf1b9e Cr-Commit-Position: refs/heads/master@{#396498}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Only unown histograms that have other owners. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 16 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ppi
Hi Alexei, ptal.
4 years, 8 months ago (2016-04-26 10:49:06 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/1920183002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1920183002/diff/1/tools/metrics/histograms/histograms.xml#oldcode18369 tools/metrics/histograms/histograms.xml:18369: - <owner>ppi@chromium.org</owner> Histograms shouldn't be left unowned? Can you ...
4 years, 8 months ago (2016-04-26 14:47:54 UTC) #4
ppi
On 2016/04/26 14:47:54, Alexei Svitkine (slow) wrote: > https://codereview.chromium.org/1920183002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (left): > > ...
4 years, 6 months ago (2016-05-27 15:06:54 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-05-27 15:07:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920183002/20001
4 years, 6 months ago (2016-05-27 15:09:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 17:23:03 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:25:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4991ff9b338a6241ed9e69328e5acb0d25bf1b9e
Cr-Commit-Position: refs/heads/master@{#396498}

Powered by Google App Engine
This is Rietveld 408576698