|
Reland [css-grid] Implement auto-repeat computation
Original CL (1895443002) was reverted because it triggered several
use-of-uninitialized-value errors on Linux WebKit Linux MSan bot. See
crbug.com/589460#c9 for details.
This CL properly initializes the two variables that were used before being
initialized using the appropriate ComputedStyle::initializeXXX() methods.
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
BUG= 589460
Committed: https://crrev.com/4deb0b181b62f4ccc93df3ea08a925d41b6c8e8a
Cr-Commit-Position: refs/heads/master@{#389746}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+2861 lines, -51 lines) |
Patch |
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-columns.html
|
View
|
|
1 chunk |
+144 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
|
View
|
|
1 chunk |
+148 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-auto-repeat-tracks.html
|
View
|
|
1 chunk |
+136 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt
|
View
|
|
1 chunk |
+25 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html
|
View
|
|
1 chunk |
+10 lines, -8 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt
|
View
|
|
1 chunk |
+24 lines, -24 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001.html
|
View
|
|
1 chunk |
+179 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001-expected.html
|
View
|
|
1 chunk |
+193 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002.html
|
View
|
|
1 chunk |
+183 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002-expected.html
|
View
|
|
1 chunk |
+190 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003.html
|
View
|
|
1 chunk |
+182 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003-expected.html
|
View
|
|
1 chunk |
+191 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004.html
|
View
|
|
1 chunk |
+184 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004-expected.html
|
View
|
|
1 chunk |
+193 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005.html
|
View
|
|
1 chunk |
+378 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005-expected.html
|
View
|
|
1 chunk |
+384 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
|
View
|
|
2 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/layout/LayoutGrid.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/layout/LayoutGrid.cpp
|
View
|
|
4 chunks |
+109 lines, -10 lines |
0 comments
|
Download
|
Total messages: 8 (3 generated)
|