Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1920163004: Remove AttachmentInfo from VulkanViewer setup (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove AttachmentInfo from VulkanViewer setup It's not necessary to pass this information back up to the client; we can store it in the TestContext if needed for Surface creation. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920163004 Committed: https://skia.googlesource.com/skia/+/a4b0fed3b7ea32ecaa16db03ff2fea37461b554f

Patch Set 1 #

Patch Set 2 : Remove unneeded members. #

Patch Set 3 : Restore check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M src/gpu/vk/GrVkCaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/VulkanTestContext.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/vulkan/VulkanTestContext.cpp View 1 3 chunks +6 lines, -17 lines 0 comments Download
M tools/vulkan/Window.h View 1 chunk +1 line, -6 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/win/Window_win.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/vulkan/win/Window_win.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 7 months ago (2016-04-27 18:10:05 UTC) #4
egdaniel
lgtm
4 years, 7 months ago (2016-04-27 18:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920163004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920163004/40001
4 years, 7 months ago (2016-04-27 18:24:26 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 18:42:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a4b0fed3b7ea32ecaa16db03ff2fea37461b554f

Powered by Google App Engine
This is Rietveld 408576698