Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8615)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 1920153002: Fix an issue in checkbox handler to enable extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 7adab1e3d308fda4a3c4f9830637f5a8b31fa7a7..16fe4cc1826823e56b48840abe6a79c7b68e5887 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -547,10 +547,11 @@ cr.define('extensions', function() {
});
// The 'Enabled' checkbox.
- wrapper.setupColumn('enabled', '.enable-checkbox input', 'change',
+ wrapper.setupColumn('enabled', '.enable-checkbox input', 'click',
function(e) {
var checked = e.target.checked;
- // TODO(devlin): What should we do if this fails?
Devlin 2016/04/27 13:52:01 nit: I think this isn't entirely addressed - the s
lazyboy 2016/04/27 22:12:55 Ah, got it. I've also updated the document to say
+ // Even if this fails, e.preventDefault() call below would keep stuff
+ // consistent.
chrome.management.setEnabled(extension.id, checked);
// This may seem counter-intuitive (to not set/clear the checkmark)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698