Fix an issue in checkbox handler to enable extension.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 cr.define('extensions', function() {
   'use strict';
 
   var ExtensionType = chrome.developerPrivate.ExtensionType;
@@ skipping 529 matching lines @@
         chrome.developerPrivate.reload(extension.id, {failQuietly: true});
       });
 
       // The 'Repair' corrupted link.
       wrapper.setupColumn('repair', '.corrupted-repair-button', 'click',
                           function(e) {
         chrome.developerPrivate.repairExtension(extension.id);
       });
 
       // The 'Enabled' checkbox.
-      wrapper.setupColumn('enabled', '.enable-checkbox input', 'change',
+      wrapper.setupColumn('enabled', '.enable-checkbox input', 'click',
                           function(e) {
         var checked = e.target.checked;
-        // TODO(devlin): What should we do if this fails?

[Devlin, 2016/04/27 13:52:01]

nit: I think this isn't entirely addressed - the state is accurate, but we don't
surface any kind of error to the user, etc.  It just looks totally broken then. 
So let's go ahead and leave in the TODO.

[lazyboy, 2016/04/27 22:12:55]

Ah, got it.
I've also updated the document to say we want to show some kind of error to the
user.
Done.

+        // Even if this fails, e.preventDefault() call below would keep stuff
+        // consistent.
         chrome.management.setEnabled(extension.id, checked);
 
         // This may seem counter-intuitive (to not set/clear the checkmark)
         // but this page will be updated asynchronously if the extension
         // becomes enabled/disabled. It also might not become enabled or
         // disabled, because the user might e.g. get prompted when enabling
         // and choose not to.
         e.preventDefault();
       });
 
@@ skipping 511 matching lines @@
         this.createWrapper_(extension, nextExt ? $(nextExt.id) : null);
       }
     }
   };
 
   return {
     ExtensionList: ExtensionList,
     ExtensionListDelegate: ExtensionListDelegate
   };
 });