Add a fuzzer for DNS hosts parser

Add a fuzzer for DNS hosts parser

BUG=600006
Committed: https://crrev.com/273af9f81bc0dea4e77d1f527e9c45f3f2dd676d
Cr-Commit-Position: refs/heads/master@{#390433}

[Zhongyi Shi, 2016-04-28 01:17:50]

Patchset #1 (id:1) has been deleted

[Zhongyi Shi, 2016-04-28 02:52:41]

zhongyi@chromium.org changed reviewers:
+ mmenke@chromium.org

[Zhongyi Shi, 2016-04-28 02:52:41]

Hi Matt,
 
I was trying to fuzz the dns host parser. Is this patch doing correctly? Can you
review that?  Thanks!

[mmenke, 2016-04-28 16:20:02]

mmenke@chromium.org changed reviewers:
+ aizatsky@chromium.org

[mmenke, 2016-04-28 16:20:03]

LGTM!

[+aizatsky]:  FYI.

https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
File net/dns/dns_hosts_parse_fuzzer.cc (right):

https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
net/dns/dns_hosts_parse_fuzzer.cc:16: net::ParseHosts(input, &dns_hosts);
I'd suggest calling ParseHostsWithCommaModeForTesting with both comma modes on
the input, instead of ParseHosts, just to make sure we cover all our bases.

[Zhongyi Shi, 2016-04-28 17:35:17]

Thanks for reviewing. I have changed the code to test with both comma modes. 

FYI, the red bots with compile error is not introduced by this CL. 

aizatsky@: could you take a look? Thanks!

https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
File net/dns/dns_hosts_parse_fuzzer.cc (right):

https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
net/dns/dns_hosts_parse_fuzzer.cc:16: net::ParseHosts(input, &dns_hosts);
On 2016/04/28 16:20:03, mmenke wrote:
> I'd suggest calling ParseHostsWithCommaModeForTesting with both comma modes on
> the input, instead of ParseHosts, just to make sure we cover all our bases.

Done. Thanks:D

[mmenke, 2016-04-28 17:45:24]

Still LGTM.  Sorry, I meant to CC aizatsky instead of adding him as a review.  I
don't think there's a need to wait on him before landing, the fuzzer team just
asked to be CCed on new fuzzer bugs, so they can keep up with what we're doing,
and chime in if needed.

On 2016/04/28 17:35:17, Zhongyi Shi wrote:
> Thanks for reviewing. I have changed the code to test with both comma modes. 
> 
> FYI, the red bots with compile error is not introduced by this CL. 
> 
> aizatsky@: could you take a look? Thanks!
> 
>
https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
> File net/dns/dns_hosts_parse_fuzzer.cc (right):
> 
>
https://codereview.chromium.org/1920093005/diff/20001/net/dns/dns_hosts_parse...
> net/dns/dns_hosts_parse_fuzzer.cc:16: net::ParseHosts(input, &dns_hosts);
> On 2016/04/28 16:20:03, mmenke wrote:
> > I'd suggest calling ParseHostsWithCommaModeForTesting with both comma modes
on
> > the input, instead of ParseHosts, just to make sure we cover all our bases.
> 
> Done. Thanks:D

[mmenke, 2016-04-28 17:45:48]

Description was changed from

==========
Add a fuzzer for DNS hosts parser

BUG=600006
==========

to

==========
Add a fuzzer for DNS hosts parser

BUG=600006
==========

[mmenke, 2016-04-28 17:45:48]

mmenke@chromium.org changed reviewers:
- aizatsky@chromium.org

[Zhongyi Shi, 2016-04-28 17:51:43]

Ah, gotcha, thanks for clarifications!

[Zhongyi Shi, 2016-04-28 17:52:10]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920093005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920093005/40001

[commit-bot: I haz the power, 2016-04-28 18:46:47]

Description was changed from

==========
Add a fuzzer for DNS hosts parser

BUG=600006
==========

to

==========
Add a fuzzer for DNS hosts parser

BUG=600006
==========

[commit-bot: I haz the power, 2016-04-28 18:46:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:19:54]

Patchset 2 (id:??) landed as
https://crrev.com/273af9f81bc0dea4e77d1f527e9c45f3f2dd676d
Cr-Commit-Position: refs/heads/master@{#390433}

[commit-bot: I haz the power, 2016-04-30 17:56:42]

Description was changed from

==========
Add a fuzzer for DNS hosts parser

BUG=600006
==========

to

==========
Add a fuzzer for DNS hosts parser

BUG=600006

Committed: https://crrev.com/273af9f81bc0dea4e77d1f527e9c45f3f2dd676d
Cr-Commit-Position: refs/heads/master@{#390433}
==========