Issue 192004: Change the default cookie policy to be closer to the default in WebKit's Dump...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192004: Change the default cookie policy to be closer to the default in WebKit's Dump... (Closed)

Created:
11 years, 3 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the default cookie policy to be closer to the default in WebKit's DumpRenderTree. Add a method to the layout test controller to allow changing the cookie policy. BUG=20356 TEST=http/tests/xmlhttprequest/cross-origin-cookie-storage.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25434

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -5 lines)			Patch
M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	1 2 3	6 chunks	+13 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/simple_resource_loader_bridge.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_resource_loader_bridge.cc	View	1 2 3 4 5 6	7 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 3 months ago (2009-09-04 05:25:03 UTC) #2

LGTM except for:

http://codereview.chromium.org/192004/diff/7001/7002
File webkit/tools/test_shell/simple_resource_loader_bridge.cc (right):

http://codereview.chromium.org/192004/diff/7001/7002#newcode720
Line 720: void SimpleResourceLoaderBridge::SetAcceptAllCookies(bool
acceptAllCookies) {
nit: accept_all_cookies

http://codereview.chromium.org/192004/diff/7001/7003
File webkit/tools/test_shell/simple_resource_loader_bridge.h (right):

http://codereview.chromium.org/192004/diff/7001/7003#newcode37
Line 37: static void SetAcceptAllCookies(bool acceptAllCookies);
nit: accept_all_cookies

Expand Messages | Collapse Messages