Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1920033007: Fix arm detection code in gn. (Closed)

Created:
4 years, 7 months ago by saiarcot895
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix arm detection code in gn. The current code calls substr(3), which gets the substring starting from index 3 up to the end of the string. However, on Ubuntu armhf (and likely other systems), arm is the first three characters, and the original intention was likely to get the substring of length 3 starting from the beginning of the string. R=brettw@chromium.org BUG=607385 Committed: https://crrev.com/b68180a770804afde260b0f1c9747f10139b20b3 Cr-Commit-Position: refs/heads/master@{#390507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/args.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
saiarcot895
4 years, 7 months ago (2016-04-28 12:54:28 UTC) #1
brettw
lgtm
4 years, 7 months ago (2016-04-28 20:22:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920033007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920033007/1
4 years, 7 months ago (2016-04-28 20:53:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 22:25:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b68180a770804afde260b0f1c9747f10139b20b3
Cr-Commit-Position: refs/heads/master@{#390507}

Powered by Google App Engine
This is Rietveld 408576698