content/public/common/mojo_shell_connection.h - Issue 1920033005: services/shell: Fix running the connection-lost callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/mojo_shell_connection.h

Issue 1920033005: services/shell: Fix running the connection-lost callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/mojo_shell_connection.h

diff --git a/content/public/common/mojo_shell_connection.h b/content/public/common/mojo_shell_connection.h

index 87209697634b1e1a2b6ec6f72488a11fd66e2f54..fc5e47a6bbbc1e93966f2474a32ab5361b21d9dd 100644

--- a/content/public/common/mojo_shell_connection.h

+++ b/content/public/common/mojo_shell_connection.h

@@ -64,7 +64,9 @@ class CONTENT_EXPORT MojoShellConnection {

// a shell embedded in the browser process (false).

virtual bool UsingExternalShell() const = 0;

- // Sets a closure that is called when the connection is lost.

+ // Sets a closure that is called when the connection is lost. Note that

+ // connection may already have been closed, in which case |closure| will be

+ // run immediately before returning from this function.

virtual void SetConnectionLostClosure(const base::Closure& closure) = 0;

// [De]Register an impl of Listener that will be consulted when the wrapped

« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | services/shell/public/cpp/lib/application_runner.cc » ('j') | no next file with comments »