services/shell/public/cpp/lib/application_runner.cc - Issue 1920033005: services/shell: Fix running the connection-lost callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/lib/application_runner.cc

Issue 1920033005: services/shell: Fix running the connection-lost callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/common/mojo_shell_connection.h ('k') | services/shell/public/cpp/lib/shell_connection.cc » ('j') | services/shell/public/cpp/lib/shell_connection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/shell/public/cpp/lib/application_runner.cc

diff --git a/services/shell/public/cpp/lib/application_runner.cc b/services/shell/public/cpp/lib/application_runner.cc

index 9f1580881afaee00578212810574ad422b1896db..2b5a0f2e627692ed4c978cda37df3956795996ee 100644

--- a/services/shell/public/cpp/lib/application_runner.cc

+++ b/services/shell/public/cpp/lib/application_runner.cc

@@ -56,7 +56,7 @@ MojoResult ApplicationRunner::Run(MojoHandle shell_client_request_handle,

mojo::MakeRequest<mojom::ShellClient>(mojo::MakeScopedHandle(

mojo::MessagePipeHandle(shell_client_request_handle)))));

base::RunLoop run_loop;

- connection_->set_connection_lost_closure(run_loop.QuitClosure());

+ connection_->SetConnectionLostClosure(run_loop.QuitClosure());

run_loop.Run();

// It's very common for the client to cache the app and terminate on errors.

// If we don't delete the client before the app we run the risk of the