Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/public/common/mojo_shell_connection.h

Issue 1920033005: services/shell: Fix running the connection-lost callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/mojo_shell_connection.h
diff --git a/content/public/common/mojo_shell_connection.h b/content/public/common/mojo_shell_connection.h
index 87209697634b1e1a2b6ec6f72488a11fd66e2f54..fc5e47a6bbbc1e93966f2474a32ab5361b21d9dd 100644
--- a/content/public/common/mojo_shell_connection.h
+++ b/content/public/common/mojo_shell_connection.h
@@ -64,7 +64,9 @@ class CONTENT_EXPORT MojoShellConnection {
// a shell embedded in the browser process (false).
virtual bool UsingExternalShell() const = 0;
- // Sets a closure that is called when the connection is lost.
+ // Sets a closure that is called when the connection is lost. Note that
+ // connection may already have been closed, in which case |closure| will be
+ // run immediately before returning from this function.
virtual void SetConnectionLostClosure(const base::Closure& closure) = 0;
// [De]Register an impl of Listener that will be consulted when the wrapped

Powered by Google App Engine
This is Rietveld 408576698