Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1920023004: aw: Fix dcheck failure on start up (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix dcheck failure on start up This method is called before BrowserThreads is initialized in the real webview, so crashing there. BUG=597167, 606543 Committed: https://crrev.com/2dacfffced52ae60725186d6061756d0609f01e8 Cr-Commit-Position: refs/heads/master@{#389617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/native/aw_gl_functor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
boliu
boom: https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/12510
4 years, 8 months ago (2016-04-25 23:01:46 UTC) #2
sgurun-gerrit only
On 2016/04/25 23:01:46, boliu wrote: > boom: > https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/12510 lgtm
4 years, 8 months ago (2016-04-25 23:02:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920023004/1
4 years, 8 months ago (2016-04-25 23:03:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920023004/1
4 years, 8 months ago (2016-04-25 23:10:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 23:44:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:46:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dacfffced52ae60725186d6061756d0609f01e8
Cr-Commit-Position: refs/heads/master@{#389617}

Powered by Google App Engine
This is Rietveld 408576698