[BattOr] Add real device smoke test

common/battor/battor/battor_wrapper.py

Index: common/battor/battor/battor_wrapper.py
diff --git a/common/battor/battor/battor_wrapper.py b/common/battor/battor/battor_wrapper.py
index e2966eb3c54e52e0232890b8d93dc03255580f7a..562f1e6f2ff74161d1d2d770514569fca2ca0d81 100644
--- a/common/battor/battor/battor_wrapper.py
+++ b/common/battor/battor/battor_wrapper.py
@@ -14,6 +14,18 @@ import dependency_manager
 from devil.utils import battor_device_mapping
 from devil.utils import find_usb_devices
 
+sys.path.insert(
+    1, os.path.join(os.path.dirname(__file__), '..', '..', '..', 'telemetry',
+                    'third_party', 'pyserial'))
+try:
+  import serial
+  from serial.tools import list_ports
+except:

[nednguyen, 2016/04/26 04:02:53]

We can remove this now :-)

[rnephew (Reviews Here), 2016/04/26 15:15:44]

Done.

+  print
+  print '-----------------------'
+  print serial.__file__
+  print '======================='
+  raise
 
 class BattorWrapper(object):
   """A class for communicating with a BattOr in python."""
@@ -128,9 +140,11 @@ class BattorWrapper(object):
       raise battor_error.BattorError(
           '%s is an unsupported platform.' % target_platform)
     if target_platform in ['win']:
-      # TODO: We need a way to automatically detect correct port.
-      # crbug.com/60397
-      return 'COM3'
+      for (port, desc, _) in serial.tools.list_ports.comports():

[charliea (OOO until 10-5), 2016/04/26 13:30:38]

Later on, we should probably add a flag to the BattOr Agent on Windows to do
this. something like --autodetect-battor-windows. We can't (and shouldn't) do
this by default for reasons (something being named "USB serial port" isn't
justification enough to start sending it random serial data, just in case it's
like an ICBM launcher or something), but it'd be nice if we have an "I know what
I'm doing" flag.

[nednguyen, 2016/04/26 15:10:57]

There should be way for us to grab the "Battor 3.2.1" name from the serial port,
just like how Windows manager display it. We probably just haven't digged deep
enough.

[rnephew (Reviews Here), 2016/04/26 15:15:44]

Acknowledged.

+        if 'USB Serial Port' in desc:
+          return port
+      raise battor_error.BattorError(
+          'Could not find BattOr attached to machine.')
     device_tree = find_usb_devices.GetBusNumberToDeviceTreeMap(fast=True)
     if battor_path:
       if not isinstance(battor_path, basestring):