Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 1919973002: Improve Android Quick Start Guide (Closed)

Created:
4 years, 8 months ago by liyuqian
Modified:
4 years, 8 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Patch after Derek's Comments #

Total comments: 1

Patch Set 3 : Add SDK Manager command line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M site/user/quick/android.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
liyuqian
4 years, 8 months ago (2016-04-25 18:25:53 UTC) #4
djsollen
https://codereview.chromium.org/1919973002/diff/1/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1919973002/diff/1/site/user/quick/android.md#newcode26 site/user/quick/android.md:26: bin/sync-and-gyp I'll upload a CL to make this a ...
4 years, 8 months ago (2016-04-25 18:35:16 UTC) #5
liyuqian
Revised according to your comments. https://codereview.chromium.org/1919973002/diff/1/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1919973002/diff/1/site/user/quick/android.md#newcode26 site/user/quick/android.md:26: bin/sync-and-gyp On 2016/04/25 18:35:16, ...
4 years, 8 months ago (2016-04-25 19:10:11 UTC) #6
djsollen
https://codereview.chromium.org/1919973002/diff/20001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1919973002/diff/20001/site/user/quick/android.md#newcode48 site/user/quick/android.md:48: Manger. can you also provide command line instructions since ...
4 years, 8 months ago (2016-04-25 19:23:29 UTC) #7
liyuqian
I've added the command line to open the SDK Manager.
4 years, 8 months ago (2016-04-25 20:10:15 UTC) #8
djsollen
lgtm
4 years, 8 months ago (2016-04-25 20:11:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919973002/40001
4 years, 8 months ago (2016-04-25 20:14:42 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:15:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8528912215f0b117ade2731c1e3158895e3bacb5

Powered by Google App Engine
This is Rietveld 408576698