Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3109)

Unified Diff: build/common.gypi

Issue 1919903002: Revert of Add Archive step for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9368049d22e875e640a8f46e0963cbc5f63a44f8..74836e7ab5931378d7b5a7d0853e031a1ba6e1aa 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3573,15 +3573,6 @@
},
}],
],
- },
- }],
- [ 'OS=="ios"', {
- 'Archive': {
- 'inherit_from': ['Common_Base', 'x86_Base', 'Release_Base'],
- 'xcode_settings': {
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
- 'STRIP_INSTALLED_PRODUCT': 'YES',
- },
},
}],
[ 'OS=="win"', {
@@ -5041,6 +5032,7 @@
# GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
@@ -5128,20 +5120,6 @@
],
}],
],
- }],
- ['OS=="mac"', {
- 'xcode_settings': {
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
- },
- }],
- ['OS=="ios"', {
- 'xcode_settings': {
- # XCTests inject a dynamic library into the application. If
- # fvisibility is set to hidden, then some symbols needed by
- # XCTests are not available. This setting is enabled for the
- # Archive configuration.
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
- },
}],
],
'target_conditions': [
@@ -5447,7 +5425,7 @@
'Release_Base': {
'xcode_settings': {
'DEPLOYMENT_POSTPROCESSING': 'YES',
- 'STRIP_INSTALLED_PRODUCT': 'NO',
+ 'STRIP_INSTALLED_PRODUCT': 'YES',
'conditions': [
['buildtype=="Official"', {
'DEBUG_INFORMATION_FORMAT': 'dwarf-with-dsym',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698