Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1919903002: Revert of Add Archive step for iOS builds. (Closed)

Created:
4 years, 8 months ago by justincohen
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Archive step for iOS builds. (patchset #4 id:60001 of https://codereview.chromium.org/1907053003/ ) Reason for revert: Downstream iOS CLs aren't ready for this yet. Reverting for now. Original issue's description: > Add Archive step for iOS builds. > > Future xctest support will set the test's bundle_loader to Chromium and look > for Chromium internals. Setting `-fvisibility=hidden` during compile and > stripping after linking makes graybox testing from xctest impossible. > > Instead, add a new 'Archive' configuration -- the same as what Xcode does -- > where visibility is set to hidden and stripping is done after linking, but skip > those steps on the remaining configurations. > > This CL should land concurrently with an official bot script change to compile > `ninja -C out/Release-iphoneos ; ninja -C out/Archive-iphoneos chrome` > and to pull official binaries from out/Archive-iphoneos instead of > Release-iphoneos. > > BUG= > TBR=thakis@chromium.org > > Committed: https://crrev.com/aeaf816fe1be6ef1fc9f71a205bcc21e9625964f > Cr-Commit-Position: refs/heads/master@{#389404} TBR=sdefresne@chromium.org,baxley@chromium.org,rohitrao@chromium.org,smut@google.com,mark@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b649ffbfb9492874a09804ca9d5b67bdc7967938 Cr-Commit-Position: refs/heads/master@{#389479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M build/common.gypi View 4 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
justincohen
Created Revert of Add Archive step for iOS builds.
4 years, 8 months ago (2016-04-25 15:04:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919903002/1
4 years, 8 months ago (2016-04-25 15:04:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 15:04:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b649ffbfb9492874a09804ca9d5b67bdc7967938 Cr-Commit-Position: refs/heads/master@{#389479}
4 years, 8 months ago (2016-04-25 15:06:17 UTC) #5
sdefresne
4 years, 7 months ago (2016-04-27 12:35:41 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698