DescriptionRevert of Add Archive step for iOS builds. (patchset #4 id:60001 of https://codereview.chromium.org/1907053003/ )
Reason for revert:
Downstream iOS CLs aren't ready for this yet. Reverting for now.
Original issue's description:
> Add Archive step for iOS builds.
>
> Future xctest support will set the test's bundle_loader to Chromium and look
> for Chromium internals. Setting `-fvisibility=hidden` during compile and
> stripping after linking makes graybox testing from xctest impossible.
>
> Instead, add a new 'Archive' configuration -- the same as what Xcode does --
> where visibility is set to hidden and stripping is done after linking, but skip
> those steps on the remaining configurations.
>
> This CL should land concurrently with an official bot script change to compile
> `ninja -C out/Release-iphoneos ; ninja -C out/Archive-iphoneos chrome`
> and to pull official binaries from out/Archive-iphoneos instead of
> Release-iphoneos.
>
> BUG=
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/aeaf816fe1be6ef1fc9f71a205bcc21e9625964f
> Cr-Commit-Position: refs/heads/master@{#389404}
TBR=sdefresne@chromium.org,baxley@chromium.org,rohitrao@chromium.org,smut@google.com,mark@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/b649ffbfb9492874a09804ca9d5b67bdc7967938
Cr-Commit-Position: refs/heads/master@{#389479}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|