Make clang the default Android compiler.

Make clang the default Android compiler.

BUG=skia:5215
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919873003

Committed: https://skia.googlesource.com/skia/+/460f40507e5dfb1324681b4b1cbe7b431f69e668

[djsollen, 2016-04-25 15:35:40]

Description was changed from

==========
Make clang the default Android compiler.

BUG=skia:5215
==========

to

==========
Make clang the default Android compiler.

BUG=skia:5215
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[djsollen, 2016-04-25 15:36:24]

djsollen@google.com changed reviewers:
+ borenet@google.com, mtklein@google.com

[mtklein, 2016-04-25 17:44:17]

https://codereview.chromium.org/1919873003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (left):

https://codereview.chromium.org/1919873003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:624: 'cflags': ['-g']
Was this redundant?

https://codereview.chromium.org/1919873003/diff/1/gyp/freetype.gyp
File gyp/freetype.gyp (right):

https://codereview.chromium.org/1919873003/diff/1/gyp/freetype.gyp#newcode108
gyp/freetype.gyp:108: '-Wno-self-assign',
Probably better to add blanket '-w' to both these third_party GYPs

[borenet, 2016-04-25 17:48:39]

Depends on https://codereview.chromium.org/1917953002/

[djsollen, 2016-04-25 18:18:26]

https://codereview.chromium.org/1919873003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1919873003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:224: '-g',
yeah, it was defined here.

[mtklein, 2016-04-25 18:20:20]

lgtm

https://codereview.chromium.org/1919873003/diff/20001/gyp/freetype.gyp
File gyp/freetype.gyp (right):

https://codereview.chromium.org/1919873003/diff/20001/gyp/freetype.gyp#newcod...
gyp/freetype.gyp:105: [ 'skia_clang_build == 1', {
These don't really need to be Clang-specific now, but I guess it's fine.

[djsollen, 2016-04-25 18:29:32]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2016-04-25 18:29:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919873003/20001

[commit-bot: I haz the power, 2016-04-25 18:45:37]

Description was changed from

==========
Make clang the default Android compiler.

BUG=skia:5215
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make clang the default Android compiler.

BUG=skia:5215
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/460f40507e5dfb1324681b4b1cbe7b431f69e668
==========

[commit-bot: I haz the power, 2016-04-25 18:45:38]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/460f40507e5dfb1324681b4b1cbe7b431f69e668