Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Iterable.h

Issue 1919873002: binding: Uses the function's context in forEach(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/Iterable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/Iterable.h b/third_party/WebKit/Source/bindings/core/v8/Iterable.h
index e493adbdd2ea4402a01ed7ebcd5fa925aeedda44..b345178e46e17b347d6636eb6ab424cc49915b7b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/Iterable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/Iterable.h
@@ -46,8 +46,8 @@ public:
v8::Isolate* isolate = scriptState->isolate();
v8::TryCatch tryCatch(isolate);
- v8::Local<v8::Object> creationContext(scriptState->context()->Global());
v8::Local<v8::Function> v8Callback(callback.v8Value().As<v8::Function>());
+ v8::Local<v8::Object> creationContext(v8Callback.As<v8::Object>());
v8::Local<v8::Value> v8ThisArg(thisArg.v8Value());
v8::Local<v8::Value> args[3];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698