Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1919853002: 🔄Add tag to background service launch logging. (Closed)

Created:
4 years, 8 months ago by Yaron
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, Marc Treib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tag to background service launch logging. I saw a few of these events - 1 per second - in a logcat. Add a tag to help identify offender. Committed: https://crrev.com/68a2fe536c8e5073c9b858be71ef1ad5630e93e1 Cr-Commit-Position: refs/heads/master@{#389499}

Patch Set 1 #

Messages

Total messages: 19 (9 generated)
Yaron
4 years, 8 months ago (2016-04-25 14:23:12 UTC) #3
Bernhard Bauer
LGTM FYI, we had a recent bug with this (https://crbug.com/605506), which has been fixed in ...
4 years, 8 months ago (2016-04-25 14:57:17 UTC) #4
Yaron
ah, that was probably it. seems worth including though. thanks for ptr
4 years, 8 months ago (2016-04-25 14:59:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919853002/1
4 years, 8 months ago (2016-04-25 14:59:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/127146)
4 years, 8 months ago (2016-04-25 15:05:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919853002/1
4 years, 8 months ago (2016-04-25 15:13:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/127157)
4 years, 8 months ago (2016-04-25 15:19:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919853002/1
4 years, 8 months ago (2016-04-25 16:37:43 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 16:46:35 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 16:49:10 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68a2fe536c8e5073c9b858be71ef1ad5630e93e1
Cr-Commit-Position: refs/heads/master@{#389499}

Powered by Google App Engine
This is Rietveld 408576698