Clarify Value::Get*()'s interface to reflect the current implementation.

Clarify Value::Get*()'s interface to reflect the current implementation.

The fact that each Get methods can be used with a NULL out-value simply to check that a value exists (and has the desired type) under a given key is used all over chrome, but isn't actually documented so this simply makes it official by documenting and testing this fact.

Also document the fact that GetDouble will succeed for TYPE_INTEGER as well as TYPE_DOUBLE (which was a surprise to me when I wrote the tests for this CL).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255834

[gab, 2014-03-08 17:08:59]

Bernhard PTAL.

Thanks!
Gab

[Bernhard Bauer, 2014-03-08 19:35:33]

LGTM! You're going to need to find an OWNER for base/ as well though.

[gab, 2014-03-09 00:54:53]

On 2014/03/08 19:35:33, Bernhard Bauer wrote:
> LGTM! You're going to need to find an OWNER for base/ as well though.

Thanks (values.cc is so core to prefs that I tend to forget your ownership
doesn't make it all the way there!)

@Nico for OWNER

Cheers!
Gab

[Nico, 2014-03-09 04:01:31]

lgtm

[gab, 2014-03-09 04:54:55]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-03-09 04:55:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/191983002/1

[commit-bot: I haz the power, 2014-03-09 04:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 04:55:28]

Try jobs failed on following builders: mac_chromium_rel

[gab, 2014-03-09 05:16:24]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-03-09 05:16:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/191983002/1

[commit-bot: I haz the power, 2014-03-09 07:13:24]

Change committed as 255834