Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI

third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/parser/CSSPropertyParser.h"
 
 #include "core/StylePropertyShorthand.h"
 #include "core/css/CSSBasicShapeValues.h"
 #include "core/css/CSSBorderImage.h"
 #include "core/css/CSSContentDistributionValue.h"
@@ skipping 1391 matching lines @@
         angle = consumeAngle(range);
 
     RawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
     if (keyword)
         list->append(keyword.release());
     if (angle)
         list->append(angle.release());
     return list.release();
 }
 
+// auto | <id> [ current | root | <target-name> ] | inherit
+static RawPtr<CSSValue> consumeNavigation(CSSParserTokenRange& range)
+{
+    CSSValueID id = range.peek().id();
+    if (id == CSSValueAuto)

[fs, 2016/05/18 15:55:05]

range.peek().id() == ...

+        return consumeIdent(range);
+
+    String selectorText = "";

[fs, 2016/05/18 15:55:05]

Don't need to initialize this, it'll be overwritten below.

+    CSSParserTokenType type = range.peek().type();
+    if (type == HashToken) {

[fs, 2016/05/18 15:55:04]

Should only accept HashToken here or?

+        selectorText.append(range.consumeIncludingWhitespace().value());
+    } else if (type == StringToken) {
+        selectorText.append(range.consumeIncludingWhitespace().value());
+    } else {
+        return nullptr;
+    }
+
+    type = range.peek().type();
+    RawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+    RawPtr<CSSValue> idSel = CSSStringValue::create(selectorText);

[fs, 2016/05/18 15:55:05]

idSelector

+    list->append(idSel.release());
+
+    RawPtr<CSSValue> target;
+    if (type == IdentToken) {
+        target = consumeIdent<CSSValueRoot, CSSValueCurrent>(range);
+    } else if (type == StringToken) {
+        String targetText = range.consumeIncludingWhitespace().value();
+        if (targetText.startsWith("_"))

[fs, 2016/05/18 15:55:05]

The way I'm reading the spec, this should not be a "hard" error (fail parsing):

"Error handling: if it does start with an underscore, "_parent" navigates to the
parent frame, "_root" is treated as root, and other values navigate to a frame
by that name if it exists. If the specified target frame does not exist, the
parameter will be treated as the keyword current, which means to simply use the
frame that the element is in."

+            return nullptr;
+        target = CSSStringValue::create(targetText);
+    } else if (type == EOFToken) {

[fs, 2016/05/18 15:55:04]

Maybe check range.atEnd() instead.

+        target = cssValuePool().createIdentifierValue(CSSValueCurrent);
+    } else {
+        return nullptr;
+    }
+    list->append(target);
+
+    return list.release();
+}
+
 static RawPtr<CSSValue> consumeTextEmphasisStyle(CSSParserTokenRange& range)
 {
     CSSValueID id = range.peek().id();
     if (id == CSSValueNone)
         return consumeIdent(range);
 
     if (RawPtr<CSSValue> textEmphasisStyle = consumeString(range))
         return textEmphasisStyle.release();
 
     RawPtr<CSSPrimitiveValue> fill = consumeIdent<CSSValueFilled, CSSValueOpen>(range);
@@ skipping 2018 matching lines @@
     case CSSPropertyWebkitTextDecorationsInEffect:
     case CSSPropertyTextDecorationLine:
         return consumeTextDecorationLine(m_range);
     case CSSPropertyD:
     case CSSPropertyMotionPath:
         return consumePathOrNone(m_range);
     case CSSPropertyMotionOffset:
         return consumeLengthOrPercent(m_range, m_context.mode(), ValueRangeAll);
     case CSSPropertyMotionRotation:
         return consumeMotionRotation(m_range);
+    case CSSPropertyNavDown:
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        return consumeNavigation(m_range);
     case CSSPropertyWebkitTextEmphasisStyle:
         return consumeTextEmphasisStyle(m_range);
     case CSSPropertyOutlineColor:
         return consumeOutlineColor(m_range, m_context.mode());
     case CSSPropertyOutlineOffset:
         return consumeLength(m_range, m_context.mode(), ValueRangeAll);
     case CSSPropertyOutlineWidth:
         return consumeLineWidth(m_range, m_context.mode(), UnitlessQuirk::Forbid);
     case CSSPropertyTransform:
         return consumeTransform(m_range, m_context.mode(), unresolvedProperty == CSSPropertyAliasWebkitTransform);
@@ skipping 1164 matching lines @@
         m_currentShorthand = oldShorthand;
         CSSParserValueList valueList(m_range);
         if (!valueList.size())
             return false;
         m_valueList = &valueList;
         return legacyParseShorthand(unresolvedProperty, important);
     }
 }
 
 } // namespace blink