Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI

third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ skipping 1308 matching lines @@
     for (auto& coordinate : coordinates) {
         auto pair = CSSValueList::createSpaceSeparated();
         pair->append(zoomAdjustedPixelValueForLength(coordinate.x(), style));
         pair->append(zoomAdjustedPixelValueForLength(coordinate.y(), style));
         list->append(pair);
     }
 
     return list.release();
 }
 
+static RawPtr<CSSValue> valueForNavigationDirection(const ComputedStyle& style, CSSPropertyID propertyID)

[fs, 2016/05/18 15:55:04]

RawPtr<T> is no more. Use T* here and in all other places in the CL.

+{
+    StyleNavigationValue navValue;
+
+    switch (propertyID) {
+    case CSSPropertyNavUp:
+        navValue = style.navUp();
+        break;
+    case CSSPropertyNavDown:
+        navValue = style.navDown();
+        break;
+    case CSSPropertyNavLeft:
+        navValue = style.navLeft();
+        break;
+    case CSSPropertyNavRight:
+        navValue = style.navRight();
+        break;
+    default:
+        ASSERT_NOT_REACHED();
+        break;
+    }
+
+    if (navValue.isAuto())
+        return cssValuePool().createIdentifierValue(CSSValueAuto);
+
+    String selectorText = "#";
+    selectorText.append(navValue.id());
+    RawPtr<CSSValue> idSel = CSSStringValue::create(selectorText);

[fs, 2016/05/18 15:55:04]

This should be a hash (not a string) - doesn't look like this serializes
correctly (doesn't round-trip.)

+    RawPtr<CSSValue> target;
+    if (navValue.navigationTarget() == TargetName)
+        target = CSSStringValue::create(navValue.targetName());
+    else if (navValue.navigationTarget() == Root)
+        target = cssValuePool().createIdentifierValue(CSSValueRoot);
+    else if (navValue.navigationTarget() == Current)
+        target = cssValuePool().createIdentifierValue(CSSValueCurrent);
+    else
+        ASSERT_NOT_REACHED();
+
+    RawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+    list->append(idSel);
+    list->append(target);
+    return list.release();
+}
+
 static EBreak mapToPageBreakValue(EBreak genericBreakValue)
 {
     switch (genericBreakValue) {
     case BreakAvoidColumn:
     case BreakColumn:
     case BreakRecto:
     case BreakVerso:
         return BreakAuto;
     case BreakPage:
         return BreakAlways;
@@ skipping 491 matching lines @@
         if (marginBottom.isFixed() || !layoutObject || !layoutObject->isBox())
             return zoomAdjustedPixelValueForLength(marginBottom, style);
         return zoomAdjustedPixelValue(toLayoutBox(layoutObject)->marginBottom(), style);
     }
     case CSSPropertyMarginLeft: {
         Length marginLeft = style.marginLeft();
         if (marginLeft.isFixed() || !layoutObject || !layoutObject->isBox())
             return zoomAdjustedPixelValueForLength(marginLeft, style);
         return zoomAdjustedPixelValue(toLayoutBox(layoutObject)->marginLeft(), style);
     }
+    case CSSPropertyNavDown:
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        return valueForNavigationDirection(style, propertyID);
+
     case CSSPropertyWebkitUserModify:
         return cssValuePool().createValue(style.userModify());
+
     case CSSPropertyMaxHeight: {
         const Length& maxHeight = style.maxHeight();
         if (maxHeight.isMaxSizeNone())
             return cssValuePool().createIdentifierValue(CSSValueNone);
         return zoomAdjustedPixelValueForLength(maxHeight, style);
     }
     case CSSPropertyMaxWidth: {
         const Length& maxWidth = style.maxWidth();
         if (maxWidth.isMaxSizeNone())
             return cssValuePool().createIdentifierValue(CSSValueNone);
@@ skipping 906 matching lines @@
     case CSSPropertyAll:
         return nullptr;
     default:
         break;
     }
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 } // namespace blink