command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer workaround

command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer workaround

Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround.

Does not remove the gpu bug workarounds entry, so that the list stays
consistent with the numbering.

This is a work aiming to improve decoder MakeCurrent performance by
making more of the state updated in lazy manner. This works towards
updating the logic for FBOs. The removed hunk was requiring the GL
binding to be up-to-date.

BUG=603407
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cb5c7ba15f5c0844f46d16158b5fb94735dea7de
Cr-Commit-Position: refs/heads/master@{#390012}

[Kimmo Kinnunen, 2016-04-25 12:49:13]

Description was changed from

==========
command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround

Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround.

Does not remove the gpu bug workarounds entry, so that the list stays
consistent with the numbering.

This is a work aiming to improve decoder MakeCurrent performance by
making more of the state updated in lazy manner. This works towards
updating the logic for FBOs. The removed hunk was requiring the GL
binding to be up-to-date.

BUG=603407
==========

to

==========
command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround

Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround.

Does not remove the gpu bug workarounds entry, so that the list stays
consistent with the numbering.

This is a work aiming to improve decoder MakeCurrent performance by
making more of the state updated in lazy manner. This works towards
updating the logic for FBOs. The removed hunk was requiring the GL
binding to be up-to-date.

BUG=603407
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kimmo Kinnunen, 2016-04-25 12:50:17]

kkinnunen@nvidia.com changed reviewers:
+ ccameron@chromium.org, piman@chromium.org

[piman, 2016-04-25 18:17:51]

Thanks for the cleanup!
Let's remove the workaround altogether - there's no point in keeping it if it
does nothing. It's ok to have holes in entry ids.

[Kimmo Kinnunen, 2016-04-26 11:07:03]

On 2016/04/25 18:17:51, piman wrote:
> Thanks for the cleanup!
> Let's remove the workaround altogether - there's no point in keeping it if it
> does nothing. It's ok to have holes in entry ids.

Done.

[piman, 2016-04-26 16:15:10]

LGTM, thanks!

[Kimmo Kinnunen, 2016-04-27 06:26:37]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-04-27 06:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919803002/20001

[commit-bot: I haz the power, 2016-04-27 07:30:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-27 07:31:41]

Description was changed from

==========
command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround

Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround.

Does not remove the gpu bug workarounds entry, so that the list stays
consistent with the numbering.

This is a work aiming to improve decoder MakeCurrent performance by
making more of the state updated in lazy manner. This works towards
updating the logic for FBOs. The removed hunk was requiring the GL
binding to be up-to-date.

BUG=603407
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround

Remove dead code for gl_begin_gl_end_on_fbo_change_to_backbuffer
workaround.

Does not remove the gpu bug workarounds entry, so that the list stays
consistent with the numbering.

This is a work aiming to improve decoder MakeCurrent performance by
making more of the state updated in lazy manner. This works towards
updating the logic for FBOs. The removed hunk was requiring the GL
binding to be up-to-date.

BUG=603407
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cb5c7ba15f5c0844f46d16158b5fb94735dea7de
Cr-Commit-Position: refs/heads/master@{#390012}
==========

[commit-bot: I haz the power, 2016-04-27 07:31:42]

Patchset 2 (id:??) landed as
https://crrev.com/cb5c7ba15f5c0844f46d16158b5fb94735dea7de
Cr-Commit-Position: refs/heads/master@{#390012}