Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1919773006: Update ninja to v1.7.0 on Mac, Linux32, Linux64, Windows. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update ninja to v1.7.0 on Mac, Linux32, Linux64, Windows. See the bug for how these were built. See the bug comment 0 also for what's new in this version. The linux binaries were built by thestig@chromium.org. The windows and mac binaries were built by thakis@chromium.org. The Windows binary is now 64-bit instead of 32-bit. BUG=607268 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M ninja.exe View Binary file 0 comments Download
M ninja-linux32 View Binary file 0 comments Download
M ninja-linux64 View Binary file 0 comments Download
M ninja-mac View Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 7 months ago (2016-04-27 22:58:33 UTC) #3
scottmg
I carefully checked the binary diff and lgtm
4 years, 7 months ago (2016-04-27 23:01:26 UTC) #4
Nico
Committed patchset #1 (id:1) manually as 300251.
4 years, 7 months ago (2016-04-27 23:13:52 UTC) #6
kooklool5566
On 2016/04/27 22:58:33, Nico wrote:
4 years, 7 months ago (2016-04-28 02:31:17 UTC) #7
kooklool5566
4 years, 7 months ago (2016-04-28 02:32:45 UTC) #8
Message was sent while issue was closed.
On 2016/04/28 02:31:17, kooklool5566 wrote:
> On 2016/04/27 22:58:33, Nico wrote:

Powered by Google App Engine
This is Rietveld 408576698