Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1919773002: Revert of Prepare for multiple ThreadHeaps (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prepare for multiple ThreadHeaps (patchset #8 id:140001 of https://codereview.chromium.org/1892713003/ ) Reason for revert: Failed TSan bots Original issue's description: > Prepare for multiple ThreadHeaps > > Convert static methods and members on ThreadHeap to non-static > > BUG=591606 > > Committed: https://crrev.com/b5cb70c9e931fad94b21fc6d8c9356b7e3860b6b > Cr-Commit-Position: refs/heads/master@{#389052} TBR=oilpan-reviews@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591606 Committed: https://crrev.com/835c8e2a01956eb74ab7c66a2612fcc27e7fed7a Cr-Commit-Position: refs/heads/master@{#389685}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -547 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 8 chunks +50 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 25 chunks +135 lines, -220 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 11 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 42 chunks +69 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.cpp View 1 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 8 chunks +33 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 24 chunks +166 lines, -106 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
keishi
Created Revert of Prepare for multiple ThreadHeaps
4 years, 8 months ago (2016-04-25 11:56:54 UTC) #1
haraken
LGTM
4 years, 8 months ago (2016-04-25 11:58:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919773002/1
4 years, 8 months ago (2016-04-25 11:59:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919773002/1
4 years, 8 months ago (2016-04-25 14:09:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/24456) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-25 14:10:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919773002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919773002/240001
4 years, 8 months ago (2016-04-25 14:44:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/127088)
4 years, 8 months ago (2016-04-25 14:50:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919773002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919773002/260001
4 years, 8 months ago (2016-04-26 01:49:14 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:260001)
4 years, 8 months ago (2016-04-26 03:42:23 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 03:43:48 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/835c8e2a01956eb74ab7c66a2612fcc27e7fed7a
Cr-Commit-Position: refs/heads/master@{#389685}

Powered by Google App Engine
This is Rietveld 408576698