Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1919733003: Change Dartium expectations from CompileTimeError to StaticWarning (Closed)

Created:
4 years, 8 months ago by Alan Knight
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Dartium expectations from CompileTimeError to StaticWarning BUG= Committed: https://github.com/dart-lang/sdk/commit/adf856186f3404602ee96a4c4c622d357da84054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
TBR
4 years, 8 months ago (2016-04-25 20:11:32 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as adf856186f3404602ee96a4c4c622d357da84054 (presubmit successful).
4 years, 8 months ago (2016-04-25 20:11:54 UTC) #4
Brian Wilkerson
4 years, 8 months ago (2016-04-25 20:12:31 UTC) #5
Message was sent while issue was closed.
I have no idea why the error level changed, but LGTM.

Powered by Google App Engine
This is Rietveld 408576698