Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 191973004: chromeos: Add external brightness control to chrome://flags. (Closed)

Created:
6 years, 9 months ago by Daniel Erat
Modified:
6 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank
Visibility:
Public.

Description

chromeos: Add external brightness control to chrome://flags. Make --ash-enable-brightness-control settable via chrome://flags to permit testing of DDC/CI-based brightness adjustments of external displays in powerd. Also add a bit of code to ensure that even if powerd announces a brightness change via D-Bus, Chrome never displays a bubble if there's no internal display connected. BUG=315371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ash/system/chromeos/brightness/tray_brightness.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Erat
6 years, 9 months ago (2014-03-09 00:15:26 UTC) #1
stevenjb
lgtm
6 years, 9 months ago (2014-03-10 23:03:28 UTC) #2
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 9 months ago (2014-03-10 23:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/191973004/1
6 years, 9 months ago (2014-03-11 00:08:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 06:08:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-11 06:08:44 UTC) #6
Daniel Erat
yay rel builders. ExtensionBrowserTest.ExternalInstallUIDoesntLeakURLRequestsOnQuickShutdown?
6 years, 9 months ago (2014-03-11 06:12:42 UTC) #7
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 9 months ago (2014-03-11 06:12:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/191973004/1
6 years, 9 months ago (2014-03-11 06:15:19 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 10:08:14 UTC) #10
Message was sent while issue was closed.
Change committed as 256176

Powered by Google App Engine
This is Rietveld 408576698